Looks pretty good as far as excercise selection goes. Why not check out "The Set/Rep Bible" by CW and use a lot of variation as far as that goes. Also I think you could use more volume on the first two days, especially the second. Utilize push/pull exercise pairings more, with supersets.
Check out "Designing your own HFT program" by Waterbury as well...he's got a relative exertion index of various exercises, and he tells you how to pair them for maximum effectiveness.
Here's what I recommend. Increase your days training to either 4 or 5, and tweak the set/rep scheme a lot. Don't go to failure, but go hit upper body at least twice, using push/pull days, with whatever works best for you and your goals. For example...
Horizontal Push/pull, dips/pullups
Vertical Push/pull, bench press/row
Mixed plane day (make sure to use different rep schemes on all 3 days), overhead press, incline press, standing upright rows
Lower body, deadlift+abs+calves
Lower body, squat+abs+calves
Obviously this will vary based on what works for you, if you are really focused on upper body that might be good, otherwise you could have two deadlift days, or two squat days instead of the mixed plane day.
I think the Waterbury articles will give you enough to design a program that really works for you. Also he has one called "Top 10 tips"...and you can always consider incorporating Perfect 10, or Ultimate Triceps Program, or 8 Weeks to Monster Shoulders, or one of his other specialty programs, into yours.
Bottom line, if you can design something really customized that works best for you, do it, otherwise (if it's nothing special) go with one of the excellent pre-made programs already here.