the best time to supplement your diet depends on your diet. Usually, i would advise you to consume whey protein sometime around your training, so either the meal before workout or the meal you are having after workout.
If you have a long time window (2-3+ hours) either before or after working out when you cannot get a 'real' meal, that would be the perfect place for whey supplementation
i googled "advocare spark" and it seems to be some sort of vitamin/electrolyte mixture with added caffeine. Whether this is 'too much' (the caffeine) depends on your personal tolerance, consumption of other caffeinated beverages throughout the day etc. I would advise against regular caffeine consumption, since the body gets used to it quite fast and from that point onward you don't really get any benefits, you just have less energy without it (which is the exact reason most people start to take caffeine to begin with)
nearly any amount (within sane limits) of fish oil is ok as long as its a quality product. However, i would rather invest at least some of the money in real cold water fish.